Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload atom-shell's binaries with Releases API #103

Merged
merged 13 commits into from
Sep 27, 2013
Merged

Upload atom-shell's binaries with Releases API #103

merged 13 commits into from
Sep 27, 2013

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Sep 27, 2013

Future releases of atom-shell will be published to the Releases page, instead of uploading to S3.

@zcbenz
Copy link
Member Author

zcbenz commented Sep 27, 2013

I'm going to update Atom's update-atom-shell-task.coffee to download atom-shell with the Releases API, but since atom-shell is private authentication would be required, should the script ask the user for a token or just has one hard-coded? /cc @kevinsawicki

@kevinsawicki
Copy link
Contributor

@zcbenz Not sure what the right answer is, let me look into what our options are first.

zcbenz added a commit that referenced this pull request Sep 27, 2013
Upload atom-shell's binaries with Releases API
@zcbenz zcbenz merged commit c029ff2 into master Sep 27, 2013
@zcbenz zcbenz deleted the releases-api branch September 27, 2013 01:46
@probablycorey
Copy link

When I looked into this last time I used the cli keychain commands (for OS
X). You can grab the users github token from those and it will prompt the
user for access to the keychain.

I can get you more info tomorrow if you need it.

On Thursday, September 26, 2013, Kevin Sawicki wrote:

@zcbenz https://github.com/zcbenz Not sure what the right answer is,
let me look into what our options are first.


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25217110
.

@kevinsawicki
Copy link
Contributor

@probablycorey did that work on CI?

@probablycorey
Copy link

Ugh, nope. I don't think that will work with CI.

On Thursday, September 26, 2013, Kevin Sawicki wrote:

@probablycorey https://github.com/probablycorey did that work on CI?


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25217366
.

@probablycorey
Copy link

We could use a combo of an env var + cli keychain. That way we don't check
in a token, CI will work and humans can use their keychain.

On Thursday, September 26, 2013, Corey Johnson wrote:

Ugh, nope. I don't think that will work with CI.

On Thursday, September 26, 2013, Kevin Sawicki wrote:

@probablycorey https://github.com/probablycorey did that work on CI?


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-25217366
.

@zcbenz
Copy link
Member Author

zcbenz commented Sep 27, 2013

@probablycorey I opened a PR for this: atom/atom#890, it would be great if you can help finish the keychain and CI parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants